Fixes test status reporting errors during successful baseline comparison #4686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards4b
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_ts_synopsisfunction's catch-all would report an error whenthe baseline comparison was actually success and had a
PASSstate.This PR fixes the issue by explicitly checking if the the CPRNC output
reports identical files first. This allows the catch-all to still function for
unknown errors that may appear in the CPRNC output.
Test suite: doctests
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a
Fixes #4685
User interface changes?: n
Update gh-pages html (Y/N)?: n