Do not show SHAREDLIB_BUILD PENDING if not building test #4767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards4b
requested changes
Mar 14, 2025
Contributor
jedwards4b
left a comment
jedwards4b
left a comment
There was a problem hiding this comment.
Please revert the change to the cprnc external, otherwise looks good. Thanks
samsrabin
force-pushed
the
avoid-sharedlib-pend-with-no-build
branch
from
4dda21f to
e23b068
Compare
Contributor
|
@samsrabin Can you address the unit test failures? |
Member
|
See comment here: #4682 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that SHAREDLIB_BUILD is not set to PENDING unless it's actually the current phase.
Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes #4682
User interface changes?: None
Update gh-pages html (Y/N)?: No