-
Notifications
You must be signed in to change notification settings - Fork 219
Fix resolving reference variables in mixed subgroups #4815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jedwards4b @jgfouca The original solution discussed for this issue was to "namespace" the value e.g. |
jedwards4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding a test for a variable which is in a subgroup, for example
JOB_WALLCLOCK_TIME
./xmlquery JOB_WALLCLOCK_TIME
Results in group case.cupid
JOB_WALLCLOCK_TIME: 48:00:00
Results in group case.st_archive
JOB_WALLCLOCK_TIME: 00:20:00
Results in group case.test
JOB_WALLCLOCK_TIME: 48:00:00
|
@jedwards4b The test is there but it's not clear, will fix. |
|
Looks like a subgroup reference would be needed for the following example. Results in group case.cupid
JOB_WALLCLOCK_TIME: $JOB_WALLCLOCK_TIME@case.cupid
Results in group case.st_archive
JOB_WALLCLOCK_TIME: 00:20:00
Results in group case.test
JOB_WALLCLOCK_TIME: 48:00:00@jedwards4b @jgfouca Any recommendations for the delimiter? Originally it was suggested to use |
|
@jasonb5 , I think |
02ea4d3 to
f3e1ddf
Compare
|
You can preview documentation at https://esmci.github.io/cime/branch/fix_mixed_subgroup_resolve/html/index.html |
Querying a variable whose value is a reference that exists
in a different
subgroupwould fail withERROR: Entry HIST_N was listed as type int but value '$STOP_N' is not valid int.This PR changes the behavior so a variable that cannot
be resolved within the current subgroup will try to resolve
from any subgroup. Finally if still not resolvable an exception
is raised.
Test suite: pytest CIME/tests/test_unit*
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes #4646
User interface changes?:
Update gh-pages html (Y/N)?: