-
Notifications
You must be signed in to change notification settings - Fork 219
test_scheduler.py: Error if Izumi nag without debug #4820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4820 +/- ##
=========================================
Coverage ? 55.21%
=========================================
Files ? 266
Lines ? 38425
Branches ? 8303
=========================================
Hits ? 21217
Misses ? 14854
Partials ? 2354 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It looks like there is at least one CESM test that uses izumi nag without debug. From <test compset="QPC6" grid="ne5pg3_ne5pg3_mg37" name="ERP_Ln9" testmods="cam/outfrq9s_clubbmf">
<machines>
<machine name="izumi" compiler="nag" category="aux_cam"/>
</machines>
<options>
<option name="wallclock">00:10:00</option>
</options>
</test>I'm not seeing this test in any expected failure list, so maybe it'd be better to do this check in CTSM instead. @ekluzek |
|
Yeah, I see that test and a few others that use izumi_nag without debug in CESM tests: from: ./query_testlists --xml-compiler nag --xml-machine izumi for lines without "_D" So we don't want to mess those tests up, and should just do a CTSM only solution. |
ekluzek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. It looks like it makes it easy to see what to do. But, it is really specific to a specific CESM case.
There is a long-standing bug, extremely difficult to diagnose, where building CESM will fail using the nag compiler on Izumi if you didn't enable debug mode. This PR makes it so that tests with such a configuration will fail with a useful error message.
Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes [CIME Github issue #]
User interface changes?: No
Update gh-pages html (Y/N)?: No