Skip to content

Conversation

@jgfouca
Copy link
Contributor

@jgfouca jgfouca commented Nov 3, 2025

This way, tests like ERP don't have to turn this on unless it's really needed.

Description

There was confusion as to why an ERP test was turning on threaded builds even though both case1 and case2 had NTHRDS=1.

Checklist

  • My code follows the style guidlines of this proejct (black formatting)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that excerise my feature/fix and existing tests continue to pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding additions and changes to the documentation

This way, tests like ERP don't have to turn this on unless
it's really needed.
@jgfouca jgfouca self-assigned this Nov 3, 2025
@jgfouca jgfouca merged commit 8774aa8 into master Nov 3, 2025
7 checks passed
@jgfouca jgfouca deleted the jgfouca/cleanup_force_smp branch November 3, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants