Fix ADIOS archiving issues in short term archiving script #4893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing short term archiving of model output allow sanity checks for files to support dangling symlinks. When archiving directories with symlinks (e.g. ADIOS BP files with symlinks to it) the directories can get archived before the symlinks. Allow sanity checks to pass even when the script finds these dangling symlinks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4893 +/- ##
===========================================
+ Coverage 20.23% 31.43% +11.20%
===========================================
Files 260 264 +4
Lines 37894 38683 +789
Branches 8042 8386 +344
===========================================
+ Hits 7666 12161 +4495
+ Misses 29354 25281 -4073
- Partials 874 1241 +367 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jgfouca
approved these changes
Nov 6, 2025
Contributor
Author
|
Archiving ADIOS BP output files failed after PR #4870 with message about missing output files. The python function to check if a file exists (os.path.exists()) requires that the symbolic links are not dangling. However when we do short term archiving some ADIOS output files get moved/archived before the associated symbolic links. So the simplest solution is to allow CIME checks in the short term archiver to allow dangling symlinks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing short term archiving of model output allow sanity checks for files to support dangling symlinks.
Also see PR #4870