Avoid creation of rpointer.*NINST_STRING files during short term archiving

[jayeshkrishna]

Avoid creating rpointer files (e.g. rpointer.atm$NINST_STRING) before completely resolving (NINST_STRING) the rpointer file name.

Fixes #4886

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.43%. Comparing base (f81f6ed) to head (eb5e6bf).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4894       +/-   ##
===========================================
+ Coverage   20.23%   31.43%   +11.20%     
===========================================
  Files         260      264        +4     
  Lines       37894    38683      +789     
  Branches     8042     8386      +344     
===========================================
+ Hits         7666    12161     +4495     
+ Misses      29354    25281     -4073     
- Partials      874     1241      +367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jayeshkrishna]

@jedwards4b : I am still seeing these invalid rpointer files when archiving E3SM output. Looking at the code it looks to me that the rpointer files need to be created per ninst_string (the loop for resolving rpointer filename and contents need to be separate from the rpointer file creation)

[jgfouca]

I am still seeing these invalid rpointer files when archiving E3SM

@jayeshkrishna , does this mean we should hold off merging?

[jayeshkrishna]

No, that was just an update in the issue (to indicate that without the PR I still see the issue). Sorry about the confusion. This PR should be good to go.