Allow fallback to find_library/find_path for netcdf #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards4b
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If netcdf libs are not installed as cmake packages, the call to find_package may fail (it depends on which FindNetCDF.cmake script is picked up, I think).
I'm not sure if this PR is desired, but on my laptop I can't get CIME to build cprnc without these mods. For some reason, the call to find_package fails. Setting CMAKE_FIND_DEBUG_MODE=ON, I can see that it doesn't use any FindNetCDF.cmake module, and therefore it can only rely on NetCDFConfig.cmake (and similar) files, which do not exist in my installation.
This PR allows us to still find netcdf if libs/includes are there, but we don't have the cmake config file. We simply look for libs/includes separately, then create the interface target.
Edit: also on my new workstation I can't get cprnc to find netcdf without this PR.