Skip to content

Conversation

@jedwards4b
Copy link
Collaborator

Merge Alpers PR #70 to master to fix github testing.

@jedwards4b jedwards4b self-assigned this Apr 30, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges Alper’s changes to convert submodule updates to asynchronous operations in order to fix GitHub testing issues.

  • Introduces asyncio for concurrent submodule updates.
  • Updates the submodules_update function (and its recursive calls) to be asynchronous, using asyncio.to_thread for blocking operations and asyncio.gather for task concurrency.
  • Modifies the main update action to use asyncio.run for invoking the new asynchronous update flow.

Copy link
Member

@alperaltuntas alperaltuntas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jedwards4b, but I think this isn't ready yet. While testing, I noticed that when re-running git-fleximod update multiple times, the following if statement evaluates to False for some submodules, unlike in the non-async version. I'm not yet certain if this is a real issue or what the fix might be, but I hope to revisit it soon. In the meantime, feel free to take a look or suggest a fix if you have ideas.

if os.path.exists(os.path.join(self.path, ".git")):

@alperaltuntas
Copy link
Member

This should be closed in favor of #73

@jedwards4b jedwards4b closed this May 20, 2025
@jedwards4b jedwards4b deleted the alper/async_checkout branch May 20, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants