Skip to content

Fix issue with recipe ref fire dependency #4420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlenh merged 4 commits into from
Apr 23, 2026
Merged

Fix issue with recipe ref fire dependency #4420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c4e7d7
Fix netCDF opening/reading and data access
jlenh Apr 23, 2026
00b9284
Remove arviz dependency in environment.yml and environment_osx.yml
jlenh Apr 23, 2026
c29c61d
Forgot to remove the dependency in pyproject.toml
jlenh Apr 23, 2026
cbd215a
Merge branch 'main' into 4419_fix_recipe_ref_fire_dependency
jlenh Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ channels:

dependencies:
- aiohttp
- arviz
- cartopy
- cdo >=2.3.0
- cdsapi
Expand Down
1 change: 0 additions & 1 deletion environment_osx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ channels:

dependencies:
- aiohttp
- arviz
- cartopy
- cdo >=2.3.0
- cdsapi
Expand Down
8 changes: 4 additions & 4 deletions esmvaltool/diag_scripts/fire/diagnostic_run_confire.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
from pathlib import Path
from typing import TYPE_CHECKING

import arviz as az
import cartopy.crs as ccrs
import cf_units
import iris
Expand All @@ -32,6 +31,7 @@
import matplotlib.pyplot as plt
import numpy as np
import pandas as pd
import xarray as xr
from matplotlib.colors import ListedColormap

from esmvaltool.diag_scripts.shared import ProvenanceLogger
Expand Down Expand Up @@ -357,11 +357,11 @@ def _select_post_param_name(name: str) -> np.array:
return np.reshape(out, new_shape)

try:
trace = az.from_netcdf(trace, engine="netcdf4")
trace = xr.open_datatree(trace, engine="netcdf4")
except (ValueError, OSError) as expt:
logger.debug("_select_post_param error %s", expt)
params = trace.to_dict()["posterior"]
params_names = params.keys()
params = trace["posterior"]
params_names = list(trace["posterior"].data_vars)
params = [_select_post_param_name(var) for var in params_names]
return params, list(params_names)

Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ dynamic = [
]
dependencies = [
"aiohttp",
"arviz",
"cartopy",
"cdo",
"cdsapi",
Expand Down
Loading