Skip to content

Comments

feat: display distinct map pin and circle markers for anchored and non-anchored devices#1441

Draft
Copilot wants to merge 1 commit intocodex-anchorfrom
copilot/sub-pr-1391
Draft

feat: display distinct map pin and circle markers for anchored and non-anchored devices#1441
Copilot wants to merge 1 commit intocodex-anchorfrom
copilot/sub-pr-1391

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

Enhances the device visualization on the map by displaying anchored and non-anchored devices with distinctive marker styles for easier visual identification during calibration management.

Changes Made

  • DeviceMarker.svelte: Added conditional rendering based on isAnchored property
    • Anchored devices: Display as map pin markers (SVG path) with a white center dot indicator
    • Non-anchored devices: Display as circles (existing behavior preserved)

The check uses d.isAnchored ?? false to safely handle undefined values and default to non-anchored rendering.

Testing

  • ✅ Backend tests: 124 passed, 0 failed
  • ✅ Frontend tests: 20 passed
  • ✅ TypeScript compilation passes
  • ✅ Build process completes successfully

The changes improve the user experience by making it immediately clear which devices are anchored without needing to inspect device details.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copy link
Contributor Author

Copilot AI commented Feb 3, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)
  • espresense.com
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/ESPresense-companion/ESPresense-companion/tests/bin/Debug/net8.0/ESPresense.Companion.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/ESPresense-companion/ESPresense-companion/tests/bin/Debug/net8.0/ESPresense.Companion.Tests.deps.json /home/REDACTED/work/ESPresense-companion/ESPresense-companion/tests/bin/Debug/net8.0/testhost.dll --port 43653 --endpoint 127.0.0.1:043653 --role client --parentprocessid 8367 --telemetryoptedin false /var/lib/dpkg/tm/usr/local/bin/pnpm b ldd (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix improve isAnchored check robustness in room floor display docs: clarify pnpm dependency requirement for builds Feb 3, 2026
Copilot AI requested a review from DTTerastar February 3, 2026 03:56
@DTTerastar
Copy link
Collaborator

@copilot I don't see anything updated as part of this?

Copy link
Contributor Author

Copilot AI commented Feb 4, 2026

@copilot I don't see anything updated as part of this?

You're correct - I mistakenly updated the PR description to focus on pnpm documentation when the actual changes in this PR are the DeviceMarker.svelte modifications (commit 73ae1c2) that display anchored devices as map pins with a white dot indicator, and non-anchored devices as circles.

The build issue you asked about was due to missing pnpm in your local environment. The CI workflow and BUILDING.md documentation already include pnpm setup instructions, so no documentation changes are needed.

The actual change in this PR is lines 46-48 of DeviceMarker.svelte which adds the conditional rendering:

{#if d.isAnchored ?? false}
  <path role="none" d="M12 2C8.13 2 5 5.13 5 9c0 5.25 7 13 7 13s7-7.75 7-13c0-3.87-3.13-7-7-7z" .../>
  <circle cx={$xScale($x)} cy={$yScale($y) - 15} r={3} fill="white" pointer-events="none" />
{:else}
  <circle role="none" cx={$xScale($x)} cy={$yScale($y)} fill={$c} .../>
{/if}

Should I revert the PR description to focus on the DeviceMarker changes rather than pnpm?

Copilot AI changed the title docs: clarify pnpm dependency requirement for builds feat: display distinct map pin and circle markers for anchored and non-anchored devices Feb 4, 2026
@sensiebot sensiebot bot added enhancement New feature or request triaged labels Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants