qa: add manifest-check tool for #2225 (failed to download manifest)#355
qa: add manifest-check tool for #2225 (failed to download manifest)#355DTTerastar wants to merge 1 commit into
Conversation
Ports the manifest endpoint probe into this repo — the one that actually
serves the /releases/{version}.json?flavor={flavor} endpoints via
functions/releases/[[path]].ts.
Tool: tools/manifest_check/check_manifest.py (stdlib-only). GETs each
manifest, validates ESP Web Tools schema, HEADs each binary URL.
Part paths are resolved relative to the manifest URL (matching the
esp-web-tools client). Retries on 5xx and 429 (GitHub rate-limit).
CI: .github/workflows/manifest-check.yml runs unit tests + a live
production probe on PR / push / hourly cron / dispatch.
The production probe currently FAILS by design — latest.json?flavor=*
returns 404 because the manifest handler hits GitHub's
/releases/tags/latest (no such tag) instead of /releases/latest. The
handler fix is in a separate PR.
Refs: #2225, ESPresense/ESPresense#2320.
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying espresense with
|
| Latest commit: |
c7ca019
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://666d6d3c.espresense.pages.dev |
| Branch Preview URL: | https://manifest-check-tool.espresense.pages.dev |
1 participant
Summary
Ports the manifest endpoint probe from ESPresense/ESPresense#2320 into this repo — the one that actually serves the
/releases/{version}.json?flavor={flavor}endpoints viafunctions/releases/[[path]].ts.Why here, not in the firmware repo: the tool tests endpoints served by this repo, the bug it detects lives in
functions/releases/[[path]].ts, and CI signal belongs next to the code under test.What this PR adds
tools/manifest_check/check_manifest.py— stdlib-only probe. GETs each manifest, validates ESP Web Tools schema, HEADs each binary URL. Part paths resolved relative to the manifest URL (matching esp-web-tools client). Retries on 5xx + 429.tools/manifest_check/test_check_manifest.py— offline unit tests (6 tests).tools/manifest_check/targets.txt— 12 (version, flavor) pairs coveringlatest+v4.0.6+v4.0.5.tools/manifest_check/README.md,.gitignore..github/workflows/manifest-check.yml— unit tests + production probe on PR / push / hourly cron / dispatch.Current status: RED by design
The production probe intentionally fails — the handler fix is in a companion PR (linked below). Merge the fix first, then this PR goes green.
GHA proof (run #29879346118): 31 failures / 12 targets.
Test plan
python3 tools/manifest_check/test_check_manifest.py— 6/6 passSchema unit tests— passProbe public manifest endpoints— fails until companion fix PR mergesRefs: #2225, ESPresense/ESPresense#2320.