Coerce lookahead_time to float above the vehicle loop

[LXMedia1]

Description

CollisionAvoidance.get_intersecting_vehicles passes settings.lookahead_time directly into Vehicle.get_path_for(...). The setting is declared as float in Plugins/CollisionAvoidance/settings.py (lookahead_time: float = 3), but in practice the slider can persist it as a string — I was hitting this with "2.5".

When the stored value is a string, Traffic/classes.py:get_path_for does:

for i in range(0, int(seconds * points_per_second)):

with seconds = "2.5" and points_per_second = 10. "2.5" * 10 is Python string repetition, so the expression becomes "2.52.52.52.52.52.52.52.52.52.5", and int(...) raises:

ValueError: invalid literal for int() with base 10: '2.52.52.52.52.52.52.52.52.52.5'

Plugin crashes, Collision Avoidance stops running until a restart.

The fix is a one-line hoist: coerce to float once at the top of get_intersecting_vehicles, then pass the local into the loop. When the setting is already numeric, float(x) is a no-op. As a side effect we also stop re-doing the attribute lookup + coercion for every tracked vehicle on every tick.

No behaviour change when the setting is numeric.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

[Copilot]

Pull request overview

Fixes a crash in the Collision Avoidance plugin when settings.lookahead_time is persisted as a string (e.g., "2.5") by coercing it to a float once before iterating over vehicles, ensuring Vehicle.get_path_for(...) receives a numeric value.

Changes:

• Hoist/cast settings.lookahead_time to a local lookahead_time: float at the top of get_intersecting_vehicles.
• Pass the coerced lookahead_time into vehicle.get_path_for(...) instead of the raw settings value.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

lookahead_time = float(settings.lookahead_time) fixes the common "2.5" string case, but the underlying reason the setting can load as a string is that ETS2LASettings casts DB values using type(default) (not the annotation). In this plugin, lookahead_time: float = 3 uses an int default, so int("2.5") fails and the raw string is kept. Consider changing the defaults in Plugins/CollisionAvoidance/settings.py to real floats (e.g., 3.0) so values are consistently loaded as floats and you may not need defensive casting here long-term.

Suggested change

	lookahead_time = float(settings.lookahead_time)
	try:
	lookahead_time = float(settings.lookahead_time)
	except (TypeError, ValueError):
	lookahead_time = 3.0