Update scripts and manifests for improved functionality and accuracy#130
Merged
Conversation
Replace Invoke-EvergreenRestMethod with Invoke-EvergreenWebRequest and capture the raw response. Decode the Unicode byte response to a string ([System.Text.Encoding]::Unicode.GetString) before running ConvertFrom-IniFile, and retain the existing string replacements to avoid parsing issues. This ensures the update INI feed is properly decoded and parsed.
Switch Get-jrsoftwareInnoSetup to use the shared Get-GitHubRepoRelease helper instead of manually resolving the download URL and parsing the ResponseUri. The script now passes the repo releases API URL, MatchVersion and file-type filter to Get-GitHubRepoRelease and returns its formatted object. The manifest was updated to point Get.Uri at the GitHub releases API, broaden the MatchVersion regex to support up to 4 numeric segments and add MatchFileTypes for .exe/.msi. Removed the previous Resolve-SystemNetWebRequest + regex extraction logic and a couple of script metadata lines.
Rename the "Name" field in Manifests/ESETPROTECTServer.json from "ESET Endpoint Antivirus" to "ESET PROTECT Server" to reflect the correct product name.
Update Manifests/MicrosoftTeams.json to change the Name field from "Microsoft Teams (new)" to "Microsoft Teams", removing the '(new)' suffix to reflect the finalized manifest name. No other changes made.
Change the Get.Uri in Manifests/PritunlOpenVPNClient.json to point to the pritunl/pritunl-client repository instead of pritunl/pritunl-client-electron. This updates the GitHub releases API endpoint used to fetch the latest client releases (likely due to a repository rename or move).
aaronparker
added
the
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoke-EvergreenWebRequestand decode the raw byte response with[System.Text.Encoding]::Unicode.GetStringbefore parsingGet-GitHubRepoReleasehelper; update manifest to point at the GitHub releases API, broadenMatchVersionregex, and addMatchFileTypesfor.exe/.msiNamefrom "ESET Endpoint Antivirus" to "ESET PROTECT Server"(new)suffix from manifestName— now simply "Microsoft Teams"Get.Urito point to thepritunl/pritunl-clientrepository (away from the oldpritunl-client-electronrepo)