Open
Conversation
Signed-off-by: MarzellT <tobias.marzell@pionix.de>
SebaLukas
requested changes
Jul 9, 2025
Member
SebaLukas
left a comment
There was a problem hiding this comment.
In general some stuff is missing:
Renegotiation:
- In Josev the case that the EV initializes renegotiation is missing. At least add a comment to this.
PMaxScheduleEntry:
- [V2G2-PnC-CharIN-022] is missing. Explicitly add an if that MaxEntriesSAScheduleTuple is not set.
SAScheduleList:
- Check if this is the case: In service HPC1, the EV always uses the first schedule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request adds the Service HPC1 as described in
"Recommendation of Charging Interface Initiative e.V. CharIN Guide ISO 15118 Service HPC1 V1.3"
Issue ticket number and link
Checklist before requesting a review