Improve code positions (match + extended assignments) #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strub
reviewed
Oct 29, 2024
Member
|
If you don't mind, making two PR (you make two things in that PR) would make more sense. (I'd like to use the PR for generating a changelog) |
Cameron-Low
force-pushed
the
zipper-upgrade
branch
from
c2461e9 to
2707d72
Compare
Contributor
Author
|
Removed the new print command from this PR. |
Member
|
Could you add an example? And then, we'll be good to go. |
Cameron-Low
force-pushed
the
zipper-upgrade
branch
2 times, most recently
from
f12f20d to
c0c2e48
Compare
Contributor
Author
|
I've added the test, and made minor changes to |
strub
changed the title
- `^match` pattern now allowed within a code pos - `#cname` can be used to select the appropriate sub-branch of a match, e.g. `^match#Some.1` - `^lv<@` and `^lv<$` are now permitted
strub
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^matchpattern now allowed within a code pos#cnamecan be used to select the appropriate sub-branch of a match^lv<@and^lv<$are now permited