Skip to content

Libretro fixes and one hotfix for YNOnline Users with loooong playtimes #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2025
+6 −6
Merged

Libretro fixes and one hotfix for YNOnline Users with loooong playtimes #3385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa71c45
libretro: Do not invoke EpAndroid
Ghabry Mar 28, 2025
1922266
libretro: Add LZH extension
Ghabry Mar 28, 2025
8027d22
Make frame counter unsigned when it is used in calculations
Ghabry Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/libretro/ui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ RETRO_API void retro_get_system_info(struct retro_system_info* info) {
info->library_name = GAME_TITLE;
info->library_version = PLAYER_VERSION_FULL;
info->need_fullpath = true;
info->valid_extensions = "ldb|zip|easyrpg";
info->valid_extensions = "ldb|zip|lzh|easyrpg";
info->block_extract = true;
}

Expand Down
4 changes: 2 additions & 2 deletions src/player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
#include "message_overlay.h"
#include "audio_midi.h"

#ifdef __ANDROID__
#if defined(__ANDROID__) && !defined(USE_LIBRETRO)
#include "platform/android/android.h"
#endif

Expand Down Expand Up @@ -376,7 +376,7 @@ void Player::Update(bool update_scene) {
Scene::instance->Update();
}

#ifdef __ANDROID__
#if defined(__ANDROID__) && !defined(USE_LIBRETRO)
EpAndroid::invoke();
#endif
}
Expand Down
2 changes: 1 addition & 1 deletion src/scene_battle_rpg2k3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ void Scene_Battle_Rpg2k3::UpdateAnimations() {
}
}

auto frame_counter = Main_Data::game_system->GetFrameCounter();
auto frame_counter = static_cast<uint32_t>(Main_Data::game_system->GetFrameCounter());

bool ally_set = false;
if (status_window->GetActive()
Expand Down
4 changes: 2 additions & 2 deletions src/tilemap_layer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ static constexpr uint8_t BlockD_Subtiles_IDS[50][2][2][2] = {
// Set of neighboring autotiles -> autotile variant
// Each neighbor is represented by a single bit (1 - same autotile, 0 - any other case)
// The bits are ordered as follows (from most to least significant bit): NW N NE W E SW S SE
static const std::unordered_map<uint8_t, int> AUTOTILE_D_VARIANTS_MAP = { //it also works with A
static const std::unordered_map<uint8_t, int> AUTOTILE_D_VARIANTS_MAP = { //it also works with A
{0b11111111, 0},
{0b01111111, 1},
{0b11011111, 2},
Expand Down Expand Up @@ -285,7 +285,7 @@ void TilemapLayer::Draw(Bitmap& dst, uint8_t z_order, int render_ox, int render_
};

// FIXME: When Game_Map singleton is made an object we can remove this null check
const auto frames = Main_Data::game_system ? Main_Data::game_system->GetFrameCounter() : 0;
const auto frames = Main_Data::game_system ? static_cast<uint32_t>(Main_Data::game_system->GetFrameCounter()) : 0u;
auto animation_step_c = (frames / 6) % 4;
auto animation_step_ab = frames / animation_speed;
if (animation_type) {
Expand Down
Loading