Urgent Android fix #3388
Merged
Urgent Android fix #3388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially this was added because the window managed of SDL2 was broken on Android
There was a problem hiding this comment.
Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (5)
- builds/android/app/build.gradle: Language not supported
- builds/android/app/src/main/AndroidManifest.xml: Language not supported
- builds/android/app/src/main/res/layout/activity_settings_video.xml: Language not supported
- builds/android/app/src/main/res/values/strings.xml: Language not supported
- builds/android/app/src/main/res/values/styles.xml: Language not supported
Comments suppressed due to low confidence (2)
builds/android/app/src/main/java/org/easyrpg/player/settings/SettingsManager.java:84
- Verify that the default value for fullscreen (true) aligns with the intended behavior of the custom theme, ensuring consistency in the user experience.
fullscreen = configIni.video.getBoolean(FULLSCREEN.toString(), true);
builds/android/app/src/main/java/org/easyrpg/player/player/EasyRpgPlayerActivity.java:144
- [nitpick] Confirm that removing the hideStatusBar call does not lead to unintended status bar visibility issues on devices not covered by the custom theme.
hideStatusBar();
Since the recent SDL2 update the system bar while a game is running is shown in green. This is distracting and this reverts it to the old look.
SDK35 changes the metrics and how the back button behaves. This breaks our app in many aspects. See EasyRPG#3373
fdelapena
approved these changes
Apr 4, 2025
carstene1ns
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our App is broken with SDK35 (#3373) now I just hope that Google Play allows this downgrade, otherwise we are kinda fcked :(
Since the last SDL2 update the systembar is green while in-game instead of black. SDL2 calls it "Fixed Immersive Mode". Imo this breaks immersion so I applied a custom theme to revert the behaviour.
Also added a Fullscreen option just because this works now with SDL2 instead. *g* (and maybe makes some users happy because the UI is not hidden anymore)