Fix CMake Linter error #3507
Open
Fix CMake Linter error #3507
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstene1ns
approved these changes
Dec 15, 2025
Member
|
The real problem is here, that GitHub provides no direct way to have the linter say "there are recommendations or possible problems" without having the workflow fail. |
Member
Author
|
Imo its fine to have the Linter fail in that case. (we should just catch it when it happens (here in the PS4 PR) and not after the merge. Likely forgot to run the workflows manually for that PR as was an external contributor) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.