Fixes Backported from v22 #1752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dolibarr#36245 use of "MAIN_CHECKBOX_LEFT_COLUMN" fix calculation of best supplier price
There was a problem hiding this comment.
Pull Request Overview
This PR backports fixes from v22 to improve supplier price handling and checkbox column positioning functionality.
Key changes:
- Added support for
MAIN_CHECKBOX_LEFT_COLUMNconfiguration to enable left-positioned action columns in supplier product lists - Fixed best supplier price calculation to use discounted unit price instead of base unit price
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| htdocs/product/fournisseurs.php | Adds conditional rendering of action column based on MAIN_CHECKBOX_LEFT_COLUMN setting and passes the setting to multiSelectArrayWithCheckbox |
| htdocs/fourn/class/fournisseur.product.class.php | Fixes minimum price calculation to compare discounted unit prices and adds type casting for safer arithmetic operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $fourn_unitprice = $fourn_price; | ||
| } | ||
| $fourn_unitprice_with_discount = $fourn_unitprice * (1 - $record["remise_percent"] / 100); | ||
| $fourn_unitprice_with_discount = (float) $fourn_unitprice * (1 - $record["remise_percent"] / 100); // backport from v22 |
There was a problem hiding this comment.
The discount calculation lacks protection against invalid percentage values. If remise_percent is greater than 100, this will result in a negative price. Consider adding validation to ensure remise_percent is within the valid range (0-100).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dolibarr#36245
use of "MAIN_CHECKBOX_LEFT_COLUMN"
fix calculation of best supplier price