Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrange editions of Eloquent JavaScript book #11826

Merged
merged 10 commits into from
Feb 5, 2025

Conversation

nilaysarma
Copy link
Contributor

What does this PR do?

Add resource(s)

Description

This PR properly arranges the different editions of the book Eloquent JavaScript.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Copy link

github-actions bot commented Feb 5, 2025

Linter failed, fix the error(s):

free-programming-books/books/free-programming-books-langs.md
1155:5-1157:118  warning  Alphabetical ordering: swap l.1156 and l.1155  alphabetize-lists  remark-lint
1155:5-1157:118  warning  Alphabetical ordering: swap l.1157 and l.1156  alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Feb 5, 2025
@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Feb 5, 2025
@eshellman
Copy link
Collaborator

just change the title from '3rd' to '4th'. We don't list multiple editions when they're available from the same site.

@nilaysarma
Copy link
Contributor Author

just change the title from '3rd' to '4th'. We don't list multiple editions when they're available from the same site.

Done!
I will take care about it in future.

@eshellman eshellman merged commit 273870f into EbookFoundation:main Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants