Skip to content

improve resources found fixing EbookFoundation/free-programming-books-parser#8#7090

Merged
eshellman merged 1 commit intoEbookFoundation:mainfrom
davorpa:bugfix/parser-8
Sep 18, 2022
Merged

improve resources found fixing EbookFoundation/free-programming-books-parser#8#7090
eshellman merged 1 commit intoEbookFoundation:mainfrom
davorpa:bugfix/parser-8

Conversation

@davorpa
Copy link
Copy Markdown
Member

@davorpa davorpa commented Sep 18, 2022

What does this PR do?

Add info | Improve repo

For resources

Description

Improve resource bugs found fixing EbookFoundation/free-programming-books-parser#8 in PR EbookFoundation/free-programming-books-parser#11

Why is this valuable (or not)?

Fixes the format of found items due to the flow change and completes their info (creators, format, notes...)

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa changed the title chore: Improve resources found fixing EbookFoundation/free-programming-books-parser/8 chore: Improve resources found fixing EbookFoundation/free-programming-books-parser#8 Sep 18, 2022
@davorpa davorpa changed the title chore: Improve resources found fixing EbookFoundation/free-programming-books-parser#8 improve resources found fixing EbookFoundation/free-programming-books-parser#8 Sep 18, 2022
@davorpa davorpa requested a review from eshellman September 18, 2022 07:45
@davorpa davorpa self-assigned this Sep 18, 2022
@davorpa davorpa added 🗣️ locale:en Resources addressing "English" language 🗣️ locale:ru Resources addressing "Russian / Русский язык" language 🗣️ locale:zh Resources addressing "Chinese" language 🗣️ locale:fa_IR Resources addressing "Persian / Farsi (Iran) / فارسى" language labels Sep 18, 2022
@davorpa davorpa marked this pull request as ready for review September 18, 2022 09:01
@eshellman eshellman merged commit 25a0581 into EbookFoundation:main Sep 18, 2022
eshellman added a commit that referenced this pull request Sep 18, 2022
@davorpa
Copy link
Copy Markdown
Member Author

davorpa commented Sep 18, 2022

@eshellman should I open again the PR? Any reason to revert it in 2e2bb31?

Let me know what happened to improve and go ahead

@davorpa davorpa deleted the bugfix/parser-8 branch September 20, 2022 07:40
@eshellman
Copy link
Copy Markdown
Collaborator

not sure what happened - maybe escaping messed up link checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗣️ locale:en Resources addressing "English" language 🗣️ locale:fa_IR Resources addressing "Persian / Farsi (Iran) / فارسى" language 🗣️ locale:ru Resources addressing "Russian / Русский язык" language 🗣️ locale:zh Resources addressing "Chinese" language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants