Skip to content

Add Qt extensions #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OrkunTokdemir
Copy link

@OrkunTokdemir OrkunTokdemir commented Apr 30, 2025

Fixes: VSCODEEXT-96

  • I have read the note above about PRs contributing or fixing extensions
  • [] I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
    I'm an official maintainer
  • [] This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR adds Qt extensions to Open VSX Registry

As a company, we signed https://www.eclipse.org/legal/eca

@OrkunTokdemir OrkunTokdemir force-pushed the orkun_add_qt_extensions_30_04_2025 branch from bc30b59 to 4dc0b87 Compare May 6, 2025 08:35
@OrkunTokdemir OrkunTokdemir force-pushed the orkun_add_qt_extensions_30_04_2025 branch from 4dc0b87 to 5627df5 Compare May 6, 2025 08:36
@OrkunTokdemir
Copy link
Author

OrkunTokdemir commented May 9, 2025

@gbraad @temoto @maxandersen @kalin Ping.

@peat-psuwit
Copy link
Contributor

peat-psuwit commented May 10, 2025

This won't work as-is. See my prior attempt (#856).

First of all, publish-extensions will not be able to figure out on its own which extension exists in which repository. So at the absolute minimum location key has to be defined.

Then, since there are multiple steps involved to build the extension in addition to standard vscode:prepublish (e.g. building qt-core, building/fetching qt-cli binary), publish-extensions will not be able to figure those steps out. So either prepublish key or custom key has to be defined.

Now, since you're the official maintainer, my understanding 1 is that it's more preferred that the extension is published by the maintainer itself. This will make the extension appears in the OpenVSX as published by (in this case) Qt rather than by OpenVSX as if it's done by publish-extension. It will also reduce a chance that publish-extension's build process gets out-of-sync with instructions in this repo.

It seems to be easy to publish a pre-built .vsix file to OpenVSX. See https://github.com/EclipseFdn/open-vsx.org/wiki/Publishing-Extensions#publishing-with-the-ovsx-command

But if you're unable to do that for any reason and need to use publish-extension, then feel free to take my code from #856 and modify it. In particular, it would be nice to modify the build of qt-core extension so that it downloads the (corresponding version of) signed qt-cli instead of building directly here.

Footnotes

  1. I'm not affiliated with Eclipse Foundation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants