Conversation
|
Looks good! Just make sure you process the comments I made for ae9a9af and I'll pull it in! |
as it matches Ed's style.
|
Bump. |
While there refactor some of the function names to make more sense. The word `next' may now refer to actually previous elements. Based on a patch by Jille Timmermans <jille@quis.cx>. Thanks!
|
But I guess the current version isn't entirely correct. You can't set the boolean field to "". Just run ./configure strict debug [...] and it should probably crash on startup now. I guess there is no sane framework right now to let boolean configuration values depend on each other. I guess the best thing to do, would be to set the boolean to no by default, and let people enable it explicitly. |
|
How about ed60922? I'm not sure whether it matches with your design-choices. (Github failed to notify me of your comment, btw) |
|
Hm... I think I'm sticking to my preference of having no config options depend on each other. Just set it to "no" by default. People need to change the config file to enable XMMS-mode anyway, so what's the problem with just adding another config switch to enable repeat? |
|
They can also use |
2 participants
No description provided.