Skip to content

Add a new makeStakeTransaction API #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
swansontec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a new makeStakeTransaction API #238

swansontec wants to merge 1 commit into from

Conversation

@swansontec
Copy link
Contributor

@swansontec swansontec commented Jul 30, 2019 •
edited
Loading

TODO:

  • Define format for EdgeStakingSettings.
  • Add this API to the EdgeCurrencyWallet.
  • Add this API to the EdgeCurrencyEngine.
  • Implement pass-through logic in the core.

@swansontec swansontec force-pushed the william/staking-api branch from 2d75299 to 56706d3 Compare July 30, 2019 20:08
@swansontec swansontec requested a review from paullinator July 30, 2019 20:23
@swansontec swansontec force-pushed the william/staking-api branch 2 times, most recently from 0fb7263 to 392ad5a Compare August 2, 2019 18:26
@swansontec swansontec force-pushed the william/staking-api branch from 392ad5a to 0f758ea Compare August 20, 2019 17:30
swansontec
swansontec commented Aug 24, 2019
View reviewed changes
src/core/currency/wallet/currency-wallet-api.js
throw new Error('This currency does not support staking')
}
const tx = await engine.changeStakingSettings(stakingSettings)
update(out) // Check for changes to this.stakingSettings
Copy link
Contributor Author

@swansontec swansontec Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Need to add a callback to the engine to tell us it changed.

Copy link

@Gmayana Gmayana Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True

chazjeremyrosette
chazjeremyrosette approved these changes May 31, 2021
View reviewed changes
Copy link

@chazjeremyrosette chazjeremyrosette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.airbitz.co/javascript/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paullinator paullinator Awaiting requested review from paullinator

2 more reviewers

@Gmayana Gmayana Gmayana left review comments

@chazjeremyrosette chazjeremyrosette chazjeremyrosette approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swansontec @chazjeremyrosette @Gmayana