-
Notifications
You must be signed in to change notification settings - Fork 11
Paul/add edge asset #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Paul/add edge asset #207
Conversation
Add revolut
Have all plugins just set to undefined for now
Allows backfilling of pluginId/tokenId of all old transactions
Do not error if fiat currency is USD.
| 6 | ||
| ) ?? ''} ${payoutAmount}` | ||
| ) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Debug console.log left in production code
A console.log statement logs detailed transaction information (orderId, currencies, chain IDs, token IDs, amounts) for every completed Lifi transaction. This appears to be debug/development code that was accidentally left in. It will pollute production logs, potentially leak sensitive transaction data, and cause unnecessary I/O overhead on every completed transaction processed.
| ): Promise<EdgeAssetInfo> { | ||
| if (network == null) { | ||
| throw new Error(`Missing network for asset: ${asset}`) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing date cutoff for network field requirement
The getAssetInfo function throws an error if network is null, but unlike other partners (changehero, exolix, godex) there's no date-based cutoff to gracefully handle older transactions. The cleaner at lines 151 and 158 marks depositNetwork and settleNetwork as optional, suggesting historical transactions may not have these fields. Other partners use constants like CHAIN_FIELDS_REQUIRED_DATE to skip asset info backfill for older transactions, but sideshift throws unconditionally, which could cause the entire sync to fail when processing historical data.
e7d048f to
f8eae85
Compare
- Round robin query all rates servers - Increase batch size and query frequency - Do not write unchanged docs
f8eae85 to
8466888
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Adds chainId/pluginId/tokenId to StandardTx and updates partner adapters, DB indexes, logging, and tooling to support asset-aware reporting.
deposit/payoutChainPluginId,deposit/payoutEvmChainId, anddeposit/payoutTokenIdtoStandardTxand plumb through codebase.createScopedLogand update utilities (paginationnow takeslog).partners/{banxa, changenow, changehero, exolix, godex, letsexchange, lifi, sideshift, moonpay}.undefined) and adopt scoped logging.orderId, timestamps, and new asset fields (e.g.status + depositChainPluginId[/depositTokenId],status + payoutChainPluginId[/payoutTokenId]).initDbs: requirecouchUris; use pooled setup.start.cache,start.rates, etc.).destroyPartition: scoped logging, pass log topagination, proper exits.src/bin/testpartner.tsfor dynamic partner testing.Written by Cursor Bugbot for commit 8466888. This will update automatically on new commits. Configure here.