Skip to content

Conversation

Copy link

Copilot AI commented Dec 14, 2025

  • Understand the codebase structure and locate the issue in sdcardJobs.ts
  • Review existing tests for SD card operations
  • Add test case for NotFoundError scenario
  • Update the catch block in erase() function to handle NotFoundError
  • Run tests to verify the fix works correctly
  • Run linter to ensure code style compliance
  • Run code review and security checks
  • Update comment to reflect cross-platform nature of the issue
  • Fix TypeScript errors in test case

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix NotFoundError during SD card erase on macOS Handle NotFoundError during SD card erase on macOS Dec 14, 2025
Copilot AI requested a review from pfeerick December 14, 2025 08:52
@pfeerick
Copy link
Member

@copilot I beleive the NotFoundError issue is actually cross-platform, not macOS specific. Update the code and PR accordingly.

Copy link
Author

Copilot AI commented Dec 14, 2025

@copilot I beleive the NotFoundError issue is actually cross-platform, not macOS specific. Update the code and PR accordingly.

Updated in commit a26a64b. Changed the code comment from "Some weird macos folder or file already deleted" to "Handle stale file system handles or file already deleted" to reflect that this is a cross-platform issue.

Copilot AI changed the title Handle NotFoundError during SD card erase on macOS Handle NotFoundError during SD card erase Dec 14, 2025
@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.39%. Comparing base (66401b2) to head (4ce1774).

Files with missing lines Patch % Lines
src/shared/backend/services/sdcardJobs.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   44.40%   44.39%   -0.01%     
==========================================
  Files         108      108              
  Lines       12671    12673       +2     
  Branches      594      594              
==========================================
  Hits         5626     5626              
- Misses       7037     7039       +2     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 14, 2025

Deploying buddy with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ce1774
Status: ✅  Deploy successful!
Preview URL: https://89364241.buddy-7a6.pages.dev
Branch Preview URL: https://head.buddy-7a6.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Dec 14, 2025

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://89364241.buddy-7a6.pages.dev
✅ Storybook: https://89364241.buddy-7a6.pages.dev/storybook

@pfeerick
Copy link
Member

@copilot Your thoughts on the check results?

Copy link
Author

Copilot AI commented Dec 15, 2025

@copilot Your thoughts on the check results?

The CI test-types check is failing due to TypeScript errors in the new test case. The test is accessing data.sdcardWriteJobStatus properties without proper type assertions. I'll fix this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants