Skip to content

refactor(v12/v14/v16): cleaner 6POS RGB LED implementation #6163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

raphaelcoeffic
Copy link
Member

No description provided.

@richardclli
Copy link
Collaborator

richardclli commented Apr 28, 2025

I am thinking the 6pos of v12/v14/v16 should be mapped to function switches instead.

I have added an ADC RAW type when I worked out nb4p, in which this ADC type will be kept hidden for other purposes. And specialized driver can make use of this ADC value to trigger function switches press.

@raphaelcoeffic
Copy link
Member Author

specialized driver can make use of this ADC value to trigger function switches press

That is a possibility as well. Feel free to improve.

@helloradiosky
Copy link
Contributor

specialized driver can make use of this ADC value to trigger function switches press

That is a possibility as well. Feel free to improve.

I still need to gradually understand this application method

@helloradiosky
Copy link
Contributor

The file 'csd203-sensor.cpp' can also be moved to the 'helloradio' directory ?

@gismo2004
Copy link

gismo2004 commented Apr 28, 2025

With this, the 6POS leds are working, but the pos is not persistent anymore. If i understood correctly, the analog value is always -100 if no button is pressed which seems to be the reason for the previously used "special logic" :-)

Raw Values:

  • Button1 pressed = 524
  • Button2 pressed = 1106
  • Button3 pressed = 1630
  • Button4 pressed = 2436
  • Button5 pressed = 3222
  • Button6 pressed = 3910
  • No Button = 2

Maybe you know all this, but though to report.

@helloradiosky
Copy link
Contributor

With this, the 6POS leds are working, but the pos is not persistent anymore. If i understood correctly, the analog value is always -100 if no button is pressed which seems to be the reason for the previously used "special logic" :-)

Raw Values:

  • Button1 pressed = 524
  • Button2 pressed = 1106
  • Button3 pressed = 1630
  • Button4 pressed = 2436
  • Button5 pressed = 3222
  • Button6 pressed = 3910
  • No Button = 2

Maybe you know all this, but though to report.

button value1-6=4096/6=682.66*n

@raphaelcoeffic
Copy link
Member Author

the analog value is always -100 if no button is pressed which seems to be the reason for the previously used "special logic" :-)

Yeah, @richardclli told me so. In that case some additional logic might be needed. I’ll discuss it with him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants