fix(bw): radio_spectrum_analyser screen glitch on exit

[eried]

Summary of changes:
Just calls killEvents to prevent screen garbage when exiting

[pfeerick]

@eried What was the best way to reproduce this? The edit you've made is specific to the "telemetry receiver connected when trying to run spectrum analyser" scenario, but I'm not seeing any odd screen artefacts on a MT12 with internal MPM (or any difference with or without this PR). Just wondering if you'd run something beforehand that might account for that... 🤔

[eried]

Hi, sorry for not explaining, but here it is:

On my JUMPER T-PRO S, I go to the tools / spectrum analyzer. Press BACK and the whole screen start glitching with chars, after changing this, it works fine :)

[eried]

I can re-confirm the fix during the weekend just to be sure (In case I screwed up the commit, the "telemetry receiver connected when trying to run spectrum analyser" scenario part), and take a photo of the bug

[pfeerick]

Ok, thanks for that... I'll try tomorrow on the T-Pro S, as it could be related to the display type... but I would be surprised if this fixed it though, as you can see quite clearly the kill_events() call you added will only fire when

if (TELEMETRY_STREAMING()) {                               // telemetry active (i.e. telemetry receiver connected)
      lcdDrawCenteredText(LCD_H/2, STR_TURN_OFF_RECEIVER); // display "turn off receiver" message
      if (event == EVT_KEY_BREAK(KEY_EXIT)) {              // on pressing RTN
        killEvents(event);                                 // kill events
        popMenu();
      }
 }

Perhaps you meant to put it near the lcdDrawCenteredText(LCD_H/2, STR_STOPPING); line? Even so, killEvents() should only be killing, well, events, shouldn't really be fixing a display issue like that... 🤔 Not saying it doesn't fix the issue you saw, just wondering if this is the right fix...

What firmware version(s) have you been able to reproduce this with? Internal or External MPM (I only have internal ELRS TPro-S)?

[eried]

All the "Jolly Mon" v2.11.X versions were producing the issue, while any older ones didn't, with the 4-in-1 version of the TPro-S. I still have to test exactly, but it sounds right that telemetry_streaming section has nothing to do

[eried]

(I will test today, to solve the mystery)

[eried]

Hi again, you're right, I wrongly assumed this was the difference, but the bug is still present

I have no clue what is the issue, but this PR is clearly wrong

[eried]

Doing a little research, I think the problem is related with reusableBuffer. If I compile the tools menu with altered labels (hardcoded) the glitch doesnt happen but the second time you enter it freezes the radio (lcd goes a little dim), so the artifacts shown in the gif before are part of this label printing on tools, but not the root problem.

But it will need more investigation than my first dumb assumption :)

[eried]

EdgeTX companion doesnt show the glitched labels, but it crashes too (when going back and into the Spectrum analyzer again) 😯