-
-
Notifications
You must be signed in to change notification settings - Fork 399
fix(bw): radio_spectrum_analyser screen glitch on exit #6281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@eried What was the best way to reproduce this? The edit you've made is specific to the "telemetry receiver connected when trying to run spectrum analyser" scenario, but I'm not seeing any odd screen artefacts on a MT12 with internal MPM (or any difference with or without this PR). Just wondering if you'd run something beforehand that might account for that... 🤔 |
Hi, sorry for not explaining, but here it is: On my JUMPER T-PRO S, I go to the tools / spectrum analyzer. Press BACK and the whole screen start glitching with chars, after changing this, it works fine :) |
I can re-confirm the fix during the weekend just to be sure (In case I screwed up the commit, the "telemetry receiver connected when trying to run spectrum analyser" scenario part), and take a photo of the bug |
Ok, thanks for that... I'll try tomorrow on the T-Pro S, as it could be related to the display type... but I would be surprised if this fixed it though, as you can see quite clearly the kill_events() call you added will only fire when if (TELEMETRY_STREAMING()) { // telemetry active (i.e. telemetry receiver connected)
lcdDrawCenteredText(LCD_H/2, STR_TURN_OFF_RECEIVER); // display "turn off receiver" message
if (event == EVT_KEY_BREAK(KEY_EXIT)) { // on pressing RTN
killEvents(event); // kill events
popMenu();
}
} Perhaps you meant to put it near the What firmware version(s) have you been able to reproduce this with? Internal or External MPM (I only have internal ELRS TPro-S)? |
All the "Jolly Mon" v2.11.X versions were producing the issue, while any older ones didn't, with the 4-in-1 version of the TPro-S. I still have to test exactly, but it sounds right that telemetry_streaming section has nothing to do |
(I will test today, to solve the mystery) |
Doing a little research, I think the problem is related with But it will need more investigation than my first dumb assumption :) |
Summary of changes:
Just calls killEvents to prevent screen garbage when exiting