[codex] remove dead shifu.run demo mirror#1494
Open
tomqin93 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
=======================================
Coverage 35.09% 35.09%
=======================================
Files 54 54
Lines 4029 4029
=======================================
Hits 1414 1414
Misses 2461 2461
Partials 154 154 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes the legacy
shifurun-sshpublish steps from the release demo artifact jobs. The public installer downloads demo packages fromdemo.shifu.dev, and the latershifu.devpublish step is the active destination. Keeping the oldshifurun-sshstep causes release builds to fail before the artifacts can reachshifu.devwhenshifu.runDNS does not resolve.Will this PR make the community happier?
Yes. Tagged releases can publish the demo tarballs to the working
shifu.devhost without being blocked by a dead legacy mirror.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): N/AHow is this PR tested
azure-pipelines/azure-pipelines.ymlas YAML and confirmed noshifurunreferences remain in that pipeline file.Special notes for your reviewer:
Build 21713 failed in
CopyFilesOverSSHwhile resolving the oldshifu.runhost. The subsequentpush demo file to shifu.devstep was skipped because the previous step failed.Release note: