Skip to content

Conversation

peterstadler
Copy link
Member

@peterstadler peterstadler commented Sep 21, 2025

Description, Context and related Issue

This PR adjusts the tests "check-language-files" and "xqunit-tests" – which we already had in the old Edirom-Online repo – to the new structure of the Edirom-Online-Backend.

NB: Some xqsuite tests are currently failing due to some changes to the getLanguageString(?) function. I wouldn't want to address this in this PR since I think this should be discussed separately.

Refs #36

How Has This Been Tested?

I tested the ant build file and the two tests locally.
I could not test the Github actions since the relevant workflow is currently disabled. I propose to reactivate this workflow after this PR has been merged.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Improvement
  • Refactoring

Overview

  • I have updated the inline documentation accordingly.
  • I have performed a self-review of my code, according to the style guide
  • I have read the CONTRIBUTING document.

@peterstadler peterstadler added this to the 1.1.0 milestone Sep 21, 2025
@peterstadler peterstadler linked an issue Sep 21, 2025 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this to In Progress in Edirom Development Sep 21, 2025
@peterstadler peterstadler moved this from In Progress to Ready for Review in Edirom Development Sep 21, 2025
@daniel-jettka daniel-jettka self-requested a review September 22, 2025 08:45
Copy link
Contributor

@daniel-jettka daniel-jettka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run locally (I get reports - not sure if they are valid, if not I'll open another bug report).
I am merging this now. Want to see it in "action" :-)

@github-project-automation github-project-automation bot moved this from Ready for Review to Approved in Edirom Development Sep 23, 2025
@daniel-jettka daniel-jettka merged commit b3e34ac into develop Sep 23, 2025
1 check passed
@daniel-jettka daniel-jettka deleted the ftr-36-add-github-actions-for-building-and-testing branch September 23, 2025 11:50
@github-project-automation github-project-automation bot moved this from Approved to Done in Edirom Development Sep 23, 2025
@bwbohl bwbohl restored the ftr-36-add-github-actions-for-building-and-testing branch September 23, 2025 15:30
@bwbohl bwbohl deleted the ftr-36-add-github-actions-for-building-and-testing branch September 23, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[ftr] add Github actions for building and testing

2 participants