changed construction of frontend URL #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hizclick
approved these changes
Sep 24, 2025
github-project-automation
bot
moved this from In Progress
to Approved
in Edirom Development
daniel-jettka
deleted the
fix-106-about-window-not-displaying-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Context and related Issue
Frontend host url was not correctly derived. Changed this.
Now the about window shows correct info fetched from backend and frontend's CITATION.cff
Refs #106
How Has This Been Tested?
Tested with EditionExample and frontend running on nginx http://localhost:8089 and in eXist-db http://localhost:8080/exist/apps/Edirom-Online-Frontend/
Docker compose with respective frontend branch and edition xar specified (and unset afterwards):
export FE_BRANCH=fix-106-about-window-not-displaying-content && export EDITION_XAR=https://github.com/Edirom/EditionExample/releases/download/v0.1.1/EditionExample-0.1.1.xar && docker compose down --volumes --remove-orphans && docker compose build --no-cache && docker compose up -d && unset FE_BRANCH && unset EDITION_XARTypes of changes
Overview