resolving issue #108 by removing <base target=_blank /> #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-jettka
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
Not sure where this change was lost as this was done already in Edirom/Edirom-Online#508
Thanks for changing again. I added target attributes for links in the about window content.
(Addition: in PR508 above it was in index.xql, here it is in index.html)
daniel-jettka
deleted the
108-bug-internal-links-in-help-window-do-not-open-in-help-window
branch
daniel-jettka
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Context and related Issue
This PR resolves issue #108 "Internal links in help window do not open in help window".
Refs #108
How Has This Been Tested?
Tested on Edition example and Carl Maria von Weber-Gesamtausgabe editions.
Types of changes
Overview