Conversation
222563d to
eeab1cb
Compare
eeab1cb to
6ebf250
Compare
There was a problem hiding this comment.
(This shouldn't really be necessary but just in case)
This code was originally released as jsr:@lishaduck/effect-platform-deno under the Universal Permissive License v1.0, and was extensively based on the MIT-licensed @effect/platform-browser & @effect/platform-node-shared. I am the sole copyright holder (@pixeleet's single contribution was legally trivial), and I explicitly grant permission to relicense this code under the MIT License for use in this repository and its derivatives.
6ebf250 to
5e03fb0
Compare
|
Apologies for the ping @fubhy, but beyond resolving conflicts, what else do y'all need of me? I'd love to help get this across the finish line; I think it'd be good to get it in for v4. |
77bff95 to
0d2c29c
Compare
|
I've resolved the conflicts; the added tests pass for me locally, but I've got a bunch of unrelated failures. Can we give CI a go and see how it likes it? |
237ed0d to
8972788
Compare
|
Alright, fixed the tsconfigs. |
6486403 to
61c43fc
Compare
|
@gcanti, docs passes locally now, we'll see about CI. Thanks for helping out! |
📊 JSDoc Documentation Analysis📈 Current Analysis ResultsThis comment is automatically updated on each push. View the analysis script for details. |
bf3a36d to
5415841
Compare
|
Cool, tests pass but |
|
How is the dev tooling supposed to work here? I opened a Deno file in vscode and got type errors everywhere because I'm assuming it's loading the normal ts server too. |
Right, if you install the Deno VS Code extension, it patches the TS Language Server to be Deno's fork. |
cbfed86 to
024c3ea
Compare
024c3ea to
40ea562
Compare
Bundle Size Analysis
|
|
OH wait... @tim-smart, do you actually have Deno installed where VS Code can find it? It can't inject the server unless it can run |
Yep. The problem seems to be that I'm getting type checking from both normal typescript and deno. |
|
I thought I asked this but it doesn't seem I did 😅 Can you share your Deno LS logs (from the output panel)? There might be something suspicious in there... 😅 |


Type
Description
Init @effect/platform-deno.
Related