improve multipart error handling for incorrect content-type #5425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test case for multipart stream with wrong content-type header - Verify graceful error handling returns MultipartError with InvalidBoundary - Ensure server stability when clients send malformed multipart requests
|
xesrevinu
changed the title
xesrevinu
commented
Aug 23, 2025
| evaluate(), | ||
| Channel.suspend(() => { | ||
| let readable: Readable | NodeJS.ReadableStream | ||
| try { |
There was a problem hiding this comment.
I'm not sure if this is a recommended practice, but I checked the Effect repo and it seems that in functions with onError, the evaluate does not have try/catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Related issues: #5426
Related
Related Issue #
Closes #5426