Fix: JSONB handling in @effect/sql-drizzle with PostgreSQL #5542
Conversation
🦋 Changeset detectedLatest commit: aea2875 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if (e === null || e === undefined) return e | ||
| if (typeof e !== "string") return e | ||
| const s = e.trim() | ||
| if (!(s.startsWith("{") || s.startsWith("["))) return e |
There was a problem hiding this comment.
Will this work if you have a non-json param that starts with these characters?
There was a problem hiding this comment.
Hey @tim-smart , yes if a non-JSON param happens to start with { or [, it will attempt JSON.parse. Since parsing will fail, it falls into the catch block and simply returns the original string unchanged.
There was a problem hiding this comment.
Right, I don't think this is robust enough to merge sorry. I'm not very familiar with drizzle, but you would need to somehow identify params that are only for json columns.
2 participants
Type
Description
Closes: #5539
This PR includes Automatic JSON handling for SQL parameters: object/array values are now auto-serialized to JSON for execution, enabling seamless insertion and querying of JSON/JSONB columns without manual conversion or API changes.
Related