Open
Conversation
|
Member
|
withStackTraceLimit will introduce a stack frame so it changes the shape of the trace |
Author
|
Ah, you are correct. I will re-impl without the helper just with the check |
arlyon
force-pushed
the
arlyon/work-with-frozen-intrinsics
branch
from
c3df8ed to
1757334
Compare
Author
|
This is ready to be merged and closes #5986 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
In some places (frozen-intrinsics, deterministic sandboxes like in temporal), error is readonly to limit the amount of peturbation. This causes issues when effect assumes it can modify, leading to exceptions. This changes that code to a best-effort attempt with a silent failure. I chose to just duplicate the snippet in the ai lib.
Related
Though outside this repo, this pattern is used within node itself. The core snippet comes from their internal checks. I have added a wrapper to DRY the set, unset, and error handling.
https://github.com/nodejs/node/blob/e77694631f1642c302f664703197b5aabc65b482/lib/internal/errors.js#L246