Move API version from endpoint paths to configurable apiUrl#5921
Open
ResiDev wants to merge 2 commits intoEffect-TS:mainfrom
Open
Move API version from endpoint paths to configurable apiUrl#5921ResiDev wants to merge 2 commits intoEffect-TS:mainfrom
ResiDev wants to merge 2 commits intoEffect-TS:mainfrom
Conversation
- Remove hardcoded /v1beta/ prefix from all endpoint paths in Generated.ts GoogleClient.ts - Update default apiUrl in GoogleClient.ts to include /v1beta
🦋 Changeset detectedLatest commit: 48fe0c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
A few comments / questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Summary
Changes
/v1beta/prefix from paths in Generated.tsapiUrlto include/v1betafor backwards compatibilityWhy
The hardcoded
/v1beta/in paths prevented using alternative endpoints like Vertex AI, which uses a different URL structure. This change makes the version configurable viaapiUrlwhile maintaining full backwards compatibility.It is also makes it easier to change the version should google change it from v1beta
Example
Testing
Tested with both standard Google Generative AI and Vertex AI endpoints.
Ran pnpm test, all related tests passed.