fix(cluster): HttpLayerRouter variants for route registration in HttpRunner#6056
Conversation
🦋 Changeset detectedLatest commit: 2b6de74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
cluster doesn't support HttpLayerRouter at the moment intentionally (as HttpLayerRouter is still experimental in effect v3). In effect v4 this will change :) |
I see. const RunnerLive = PingLive.pipe(
Layer.provideMerge(BunClusterHttp.layer({ transport: "http", storage: "local"}))
)
Layer.launch(RunnerLive).pipe(BunRuntime.runMain)
|
|
Ah yep looks like when I backported some effect v4 changes it got switched to HttpLayerRouter. |
26a4755 to
2b6de74
Compare
Type
Description
HttpRunner.layerHttpOptionsandlayerWebsocketOptionsregistered routes onHttpRouter.Default, butHttpLayerRouter.serve(used bylayerHttp/layerWebsocket) serves fromHttpLayerRouter.HttpRouter— a different router tag. This caused POST/GET requests to return 404.RpcServer.layerProtocolHttpRouterandRpcServer.layerProtocolWebsocketRouterso routes are registered on the correct router.layerHttpOptionsroutes are reachable throughHttpLayerRouter.Related