Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cron-testclock-infinity.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"effect": patch
---

Fix `Schedule.cron` when the test clock is adjusted to infinity.
8 changes: 8 additions & 0 deletions packages/effect/src/internal/schedule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,14 @@ export const cron: {
return makeWithState<[boolean, [number, number, number]], unknown, [number, number]>(
[true, [Number.MIN_SAFE_INTEGER, 0, 0]],
(now, _, [initial, previous]) => {
if (!Number.isFinite(now)) {
return core.succeed([
[false, previous],
[previous[1], previous[2]],
ScheduleDecision.done
])
}

if (now < previous[0]) {
return core.succeed([
[false, previous],
Expand Down
26 changes: 25 additions & 1 deletion packages/effect/test/Effect/scheduling.test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import { describe, it } from "@effect/vitest"
import { deepStrictEqual } from "@effect/vitest/utils"
import { assertTrue, deepStrictEqual } from "@effect/vitest/utils"
import * as Clock from "effect/Clock"
import * as Cron from "effect/Cron"
import * as Deferred from "effect/Deferred"
import * as Duration from "effect/Duration"
import * as Effect from "effect/Effect"
import * as Fiber from "effect/Fiber"
import { pipe } from "effect/Function"
import * as Ref from "effect/Ref"
import * as Schedule from "effect/Schedule"
Expand Down Expand Up @@ -76,4 +79,25 @@ describe("Effect", () => {
}
])
}))

it.effect("schedule - cron does not fail when the test clock is adjusted to infinity", () =>
Effect.gen(function*() {
const ref = yield* Ref.make(0)
const latch = yield* Deferred.make<void>()
const cron = Cron.unsafeParse("0 0 4 8-14 * *", "UTC")
const schedule = pipe(Schedule.cron(cron), Schedule.intersect(Schedule.recurs(10)))
const fiber = yield* pipe(
Ref.update(ref, (n) => n + 1),
Effect.zipLeft(Deferred.await(latch)),
Effect.repeat(schedule),
Effect.fork
)

yield* TestClock.adjust(Infinity)
yield* Deferred.succeed(latch, void 0)
yield* Fiber.join(fiber)

const value = yield* Ref.get(ref)
assertTrue(value > 0)
}))
})