Conversation
🦋 Changeset detectedLatest commit: 0c2dfd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
I think we can agree the whole point of static types is to not have runtime exceptions. But sometimes it's easy to introduce them...
Now obviously I understand why this exists and it can't be avoided, it's because you can't check if a number literal in the program is prime or not at compile time... Sure, but how about an integer...
In this case we can produce a compilation error like this...
That's nice.
So that's what this PR brings in Effect. The
Brandtype can now take a "parser" which is a higher kinded type that takes avalueand returns aresultand there's now aliteralfunction on the brand constructor that uses this parser...Perhaps we should have some built-in brands/schema-filters (eg
Int,NonZero, etc) so that the users don't have to write parsers themselves.Let me know if you guys think this is a good idea. No problems if we don't want to merge this, I just wanted to throw this idea out there.
Thanks for reading!
Further reading: microsoft/TypeScript#52088