Fix effectGenToFn return type conversion#635
Merged
mattiamanzati merged 1 commit intomainfrom Feb 3, 2026
Merged
Conversation
When converting Effect.gen to Effect.fn, the return type annotation is now correctly transformed from Effect<A, E, R> to Effect.fn.Return<A, E, R>, preventing the refactor from producing code that doesn't compile. Closes #634 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 450b28c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectGenToFnrefactor to correctly convertEffect<A, E, R>return type annotations toEffect.fn.Return<A, E, R>when transformingEffect.gentoEffect.fnEffect.Effect<...>return type, producing code that doesn't compileEffect.fn.Returntype referenceExample
Before this fix, the refactor would produce:
After this fix:
Test plan
effectGenToFn_returns.tswith two cases (concise body and generics)Effect.fn.Return<A, E, R>typeCloses #634
🤖 Generated with Claude Code