docs(plan): correct Rust support plan against current codebase state - #16
Merged
Merged
Conversation
- Task A4: replace the "executor must verify" guess about trait_item's class name field with a definitive fix, confirmed against tree-sitter-rust 0.23.3's real node-types.json — trait_item has field `name`, not `type` like impl_item, so class_name_field can't stay a single per-language constant; walk_symbols needs a per-node-kind branch. - Task A3: correct pipeline.rs line citations (+21 lines throughout, from the same-file-candidate-preference fix that landed before this plan was committed) and note why, so line numbers match HEAD. - Task B5: correct the ci-server/src/lib.rs insertion point description to match the actual spawn_blocking block structure. - Task B6: rename to the existing bN_name/run_benchmark.py convention and wire it into the already-reserved "B2" row in benchmarks/README.md instead of a new ad hoc top-level folder. - Task A1: note that the shipped fix stays string-based (no nested use-group support), since the research doc's phrasing overstated scope. - Minor: fix a stale function name reference in Task A5. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013HgQtsfovjqekyVw7ZjCS9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name, nottypelike impl_item, so class_name_field can't stay a single per-language constant; walk_symbols needs a per-node-kind branch.Claude-Session: https://claude.ai/code/session_013HgQtsfovjqekyVw7ZjCS9