fix(indexer): resolve 4 dead-code/hub false-positive sources - #18
Merged
Conversation
- Preserve the module-path qualifier of fully-qualified calls (crate::mod::func()) instead of discarding it, and use it in rebuild_graph to prefer the named module over same-file-as-caller fan-out. Fixes qualified calls silently misresolving to an unrelated same-named symbol in the caller's own file (in the worst case a fabricated self-recursive edge) when there's no `use` importing the real target. - Filter ambiguous-confidence and ruled_out_by_scip edges out of the persisted symbols.caller_count, matching the callers tool's own direct_count semantics. Previously every same-named candidate in an ambiguous fan-out group inflated caller_count near-identically regardless of real usage, corrupting hub/coreness ranking and dead_code_confidence. Also refresh caller_count again after the SCIP overlay pass, since it flips the very columns this filter depends on. - Extract TypeScript interface_declaration/type_alias_declaration as symbols. A type/DTO-only .ts file previously indexed as 0 symbols, making it invisible to search/locate/file_overview. - Carry line_start/line_end through hotspots' top_symbols, so two same-named symbols in one file (e.g. a #[cfg(feature)] real impl vs. its stub) are distinguishable, matching symbol_info's existing behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHXruzGoMCTypCxhsoeuXf
Eilodon
pushed a commit
that referenced
this pull request
Jul 4, 2026
PR #18 merged without running cargo fmt, breaking the Format check step in CI on main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the module-path qualifier of fully-qualified calls (crate::mod::func()) instead of discarding it, and use it in rebuild_graph to prefer the named module over same-file-as-caller fan-out. Fixes qualified calls silently misresolving to an unrelated same-named symbol in the caller's own file (in the worst case a fabricated self-recursive edge) when there's no
useimporting the real target.Filter ambiguous-confidence and ruled_out_by_scip edges out of the persisted symbols.caller_count, matching the callers tool's own direct_count semantics. Previously every same-named candidate in an ambiguous fan-out group inflated caller_count near-identically regardless of real usage, corrupting hub/coreness ranking and dead_code_confidence. Also refresh caller_count again after the SCIP overlay pass, since it flips the very columns this filter depends on.
Extract TypeScript interface_declaration/type_alias_declaration as symbols. A type/DTO-only .ts file previously indexed as 0 symbols, making it invisible to search/locate/file_overview.
Carry line_start/line_end through hotspots' top_symbols, so two same-named symbols in one file (e.g. a #[cfg(feature)] real impl vs. its stub) are distinguishable, matching symbol_info's existing behavior.
Claude-Session: https://claude.ai/code/session_01AHXruzGoMCTypCxhsoeuXf