docs(thresholds): correct stale hotspot-risk rationale comment - #61
Merged
Conversation
The comment justifying max_hotspot_risk = 0.80 described common.rs as the churn/complexity leader (~41 commits/6mo, risk 0.74) driving the gate to within 0.01 of the 0.75 default. That story predates this repo's current git history (starts 2026-07-30, 50 commits total) — verified via `calm fitness-check --config thresholds.toml` and `git log --since="6 months ago"` that the actual max hotspot risk is 0.15 (driven by tools.rs, not common.rs, which is down to 7 commits/6mo), a margin of ~0.65 rather than ~0.01. Left the threshold at 0.80 since churn is still artificially low from the recent history reset, but corrected the comment so it no longer misleads future readers into thinking a real regression is imminent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment justifying max_hotspot_risk = 0.80 described common.rs as the churn/complexity leader (~41 commits/6mo, risk 0.74) driving the gate to within 0.01 of the 0.75 default. That story predates this repo's current git history (starts 2026-07-30, 50 commits total) — verified via
calm fitness-check --config thresholds.tomlandgit log --since="6 months ago"that the actual max hotspot risk is 0.15 (driven by tools.rs, not common.rs, which is down to 7 commits/6mo), a margin of ~0.65 rather than ~0.01. Left the threshold at 0.80 since churn is still artificially low from the recent history reset, but corrected the comment so it no longer misleads future readers into thinking a real regression is imminent.