Skip to content

Conversation

lwJi
Copy link
Contributor

@lwJi lwJi commented Oct 31, 2024

No description provided.

@lwJi lwJi requested review from eschnett and rhaas80 October 31, 2024 01:53
@lwJi lwJi force-pushed the lwji/interface branch 2 times, most recently from 397afc0 to 004ec0a Compare November 6, 2024 15:47
@lwJi lwJi changed the title CarpetX: make driver.hxx and schedule.hxx visible to other thorns CarpetX: make driver.hxx, schedule.hxx and timer.hxx visible to other thorns Nov 12, 2024
@lwJi lwJi force-pushed the lwji/interface branch from 5ff5336 to 14ea39b Compare July 3, 2025 15:53
@rhaas80
Copy link
Member

rhaas80 commented Jul 3, 2025

I believe @eschnett 's source code comment TODO: Don't include files from other thorns; create a proper interface is to be interpreted to have a set of functions calls (aliased ones?) that provide the required access to ODESolvers instead of having ODESolvers directly manipulate CarpetX's internal data structures.

What exactly does it use from the various .hxx files/

@lwJi
Copy link
Contributor Author

lwJi commented Jul 3, 2025

CarpetX::active_levels->loop_serially and so on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants