Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new thorn called
NoiseX
for providing a unified and localized interface for adding noise toCarpetX
grid functions. This thorn is useful for performing robust stability tests.ADMBaseX
already provides a mechanism for adding noise to ADM variables, but the current implemetation has a few issues:ADMBaseX
can only add noise to its own variables.ADMBaseX
provides no fine grained control over the type of noise being generated.ADMBaseX
noise generation is not reproducible.TODO
inADMBaseX
which suggest delegating noise addition to a separate thornNoiseX
allows users to choose between random (as it is done inADMBaseX
) or fixed and configurable noise seeds (for reproducibility). Furthermore it allows users to choose a noise engine for the actual generation of the pseudo-random numbers. Currently the default random engine (as used inADMBaseX
), Mersenne twister and sine wave generation engines are provided. This is done in hopes to improve user control over the numbers generated and allow for greater reproducibility.This PR also modifies
ADMBaseX
for usingNoiseX
(thus providing an example usage) and theCI
thorn list, addingNoiseX
to the CI tests.