-
Notifications
You must be signed in to change notification settings - Fork 11
CarpetX: use pinned Particles in CarpetX_Interpolate #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why do you want to use pinned particles? What is the advantage? |
I was using the |
Does this improve the speed? I do not understand how it works. The code that uses pinned memory runs in the CPU, it's the code inserting particles into the AMReX data structures. In the end, these data structures are copied out of the pinned and into the regular memory again. |
Do you have a test case? |
It seems to mostly follow the code in AMReX-Codes/amrex#4506 (reply in thread) which was judged "basic approach looks right to me" by the AMReX crowd). But not tested by them. |
The fix to the old version worked and it was much faster. |
One of the comments from the AMReX discussion mentioned that |
No description provided.