Add static analysis to CI and fix cppcheck findings

Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>

Author: jballoffet

.github/workflows/mcu-ci.yml

@@ -58,6 +58,9 @@ jobs:
       - name: Build application
         working-directory: ./andino_firmware
         run: pio run
+      - name: Run static analysis
+        working-directory: ./andino_firmware
+        run: pio check --fail-on-defect=medium
       - name: Run unit tests
         working-directory: ./andino_firmware
         run: pio test --environment=desktop

andino_firmware/include/andino/app/app.h

@@ -86,7 +86,8 @@ class App {
         left_pid_controller_(Constants::kPidKp, Constants::kPidKd, Constants::kPidKi,
                              Constants::kPidKo, -Constants::kPwmMax, Constants::kPwmMax),
         right_pid_controller_(Constants::kPidKp, Constants::kPidKd, Constants::kPidKi,
-                              Constants::kPidKo, -Constants::kPwmMax, Constants::kPwmMax) {
+                              Constants::kPidKo, -Constants::kPwmMax, Constants::kPwmMax),
+        shell_() {
   }
 
   // Delete copy and move operations to enforce unique reference ownership.

andino_firmware/include/andino/app/shell.h

@@ -98,13 +98,13 @@ class Shell {
   CommandCallback default_callback_{nullptr};
 
   /// Command registry.
-  Command commands_[kCommandsMax];
+  Command commands_[kCommandsMax]{};
 
   /// Number of registered commands.
   size_t commands_count_{0};
 
   /// Command prompt message.
-  char message_buffer_[kCommandPromptLengthMax];
+  char message_buffer_[kCommandPromptLengthMax]{};
 
   /// Command prompt message index.
   int message_index_{0};

andino_firmware/include/andino/drivers/encoder.h

@@ -127,9 +127,12 @@ class Encoder {
   static const InterruptIn::InterruptCallback kCallbacks[kInstancesMax];
 
   /// Static wrapper that redirects to the first instance callback method.
+  // cppcheck-suppress unusedPrivateFunction
+  // Referenced only through the kCallbacks function pointer table, which cppcheck can't trace.
   static void callback_0();
 
   /// Static wrapper that redirects to the second instance callback method.
+  // cppcheck-suppress unusedPrivateFunction
   static void callback_1();
 
   /// Channels interrupt callback.

andino_firmware/src/app/shell.cpp

@@ -90,7 +90,7 @@ void Shell::parse_message() {
   char* saveptr = nullptr;
 
   argv[argc] = strtok_r(message_buffer_, " ", &saveptr);
-  while (argv[argc] != NULL && argc < (kCommandArgMax - 1)) {
+  while (argc < (kCommandArgMax - 1) && argv[argc] != NULL) {
     argv[++argc] = strtok_r(NULL, " ", &saveptr);
   }