[andino_firmware] Fix several formatting and style linting issues (#328)

Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>

Author: jballoffet

andino_firmware/README.md

@@ -76,4 +76,4 @@ A serial port connection must be created at 57600 bauds. You can use the serial
 | `o` | Set open-loop speed for the motors[pwm] | left_pwm right_pwm | `o 255 255` |  |
 | `u` | Set PID values | kp kd ki offset | `u 1.0 0.1 0.01 0` |  |
 | `h` | Get if IMU is connected |  | `h` | `0` if not connected, `1` if connected |
-| `i` | Get IMU data and encoder tick values |  | `i` | `<left> <right>  <orientation_X> <orientation_Y> <orientation_Z> <orientation_W> <angular_velocity_X> <angular_velocity_Y> <angular_velocity_Z> <linear_acceleration_X> <linear_acceleration_Y> <linear_acceleration_Z>` |
+| `i` | Get IMU data and encoder tick values |  | `i` | `<left> <right>  <orientation_X> <orientation_Y> <orientation_Z> <orientation_W> <angular_velocity_X> <angular_velocity_Y> <angular_velocity_Z> <linear_acceleration_X> <linear_acceleration_Y> <linear_acceleration_Z>` |

andino_firmware/docker/README.md

@@ -54,7 +54,7 @@ The Docker Compose configuration is set up with:
 - `/dev:/dev` mount
 - `network_mode: host`
 
-This allows the container full access to USB devices connected to the host machine. 
+This allows the container full access to USB devices connected to the host machine.
 
 To upload/flash your firmware to the Arduino board:
 

andino_firmware/include/andino/app/app.h

@@ -31,16 +31,16 @@
 
 #include <Adafruit_BNO055.h>
 
-#include "andino/hal/serial_stream.h"
-#include "andino/hal/clock.h"
-#include "andino/hal/digital_out.h"
-#include "andino/hal/pwm_out.h"
-#include "andino/hal/interrupt_in.h"
-#include "andino/drivers/motor.h"
-#include "andino/drivers/encoder.h"
 #include "andino/app/constants.h"
 #include "andino/app/pid.h"
 #include "andino/app/shell.h"
+#include "andino/drivers/encoder.h"
+#include "andino/drivers/motor.h"
+#include "andino/hal/clock.h"
+#include "andino/hal/digital_out.h"
+#include "andino/hal/interrupt_in.h"
+#include "andino/hal/pwm_out.h"
+#include "andino/hal/serial_stream.h"
 
 namespace andino {
 
@@ -64,11 +64,10 @@ class App {
    * @param right_encoder_b The right encoder channel B interrupt input.
    * @param bno055_imu The Adafruit BNO055 IMU sensor.
    */
-  App(const Clock& clock, SerialStream& serial_stream,
-      DigitalOut& left_motor_enable, PwmOut& left_motor_forward, PwmOut& left_motor_backward,
-      DigitalOut& right_motor_enable, PwmOut& right_motor_forward, PwmOut& right_motor_backward,
-      InterruptIn& left_encoder_a, InterruptIn& left_encoder_b,
-      InterruptIn& right_encoder_a, InterruptIn& right_encoder_b,
+  App(const Clock& clock, SerialStream& serial_stream, DigitalOut& left_motor_enable,
+      PwmOut& left_motor_forward, PwmOut& left_motor_backward, DigitalOut& right_motor_enable,
+      PwmOut& right_motor_forward, PwmOut& right_motor_backward, InterruptIn& left_encoder_a,
+      InterruptIn& left_encoder_b, InterruptIn& right_encoder_a, InterruptIn& right_encoder_b,
       Adafruit_BNO055& bno055_imu)
       : clock_(clock),
         serial_stream_(serial_stream),
@@ -78,9 +77,10 @@ class App {
         right_encoder_(&right_encoder_a, &right_encoder_b),
         bno055_imu_(bno055_imu),
         left_pid_controller_(Constants::kPidKp, Constants::kPidKd, Constants::kPidKi,
-                              Constants::kPidKo, -Constants::kPwmMax, Constants::kPwmMax),
+                             Constants::kPidKo, -Constants::kPwmMax, Constants::kPwmMax),
         right_pid_controller_(Constants::kPidKp, Constants::kPidKd, Constants::kPidKi,
-                               Constants::kPidKo, -Constants::kPwmMax, Constants::kPwmMax) {}
+                              Constants::kPidKo, -Constants::kPwmMax, Constants::kPwmMax) {
+  }
 
   // Delete copy and move operations to enforce unique reference ownership.
   App(const App&) = delete;

andino_firmware/include/andino/app/pid.h

@@ -43,7 +43,8 @@ class Pid {
   /// @param output_min Output minimum limit.
   /// @param output_max Output maximum limit.
   Pid(int kp, int kd, int ki, int ko, int output_min, int output_max)
-      : kp_(kp), kd_(kd), ki_(ki), ko_(ko), output_min_(output_min), output_max_(output_max) {}
+      : kp_(kp), kd_(kd), ki_(ki), ko_(ko), output_min_(output_min), output_max_(output_max) {
+  }
 
   /// @brief Resets the PID controller.
   ///

andino_firmware/include/andino/bsp/digital_out_arduino.h

@@ -39,7 +39,8 @@ class DigitalOutArduino : public DigitalOut {
   /// @brief Constructs a DigitalOutArduino using the specified GPIO pin.
   ///
   /// @param gpio_pin GPIO pin.
-  explicit DigitalOutArduino(const int gpio_pin) : gpio_pin_(gpio_pin) {}
+  explicit DigitalOutArduino(const int gpio_pin) : gpio_pin_(gpio_pin) {
+  }
 
   void begin() const override;
 

andino_firmware/include/andino/bsp/interrupt_in_arduino.h

@@ -39,7 +39,8 @@ class InterruptInArduino : public InterruptIn {
   /// @brief Constructs a InterruptInArduino using the specified GPIO pin.
   ///
   /// @param gpio_pin GPIO pin.
-  explicit InterruptInArduino(const int gpio_pin) : gpio_pin_(gpio_pin) {}
+  explicit InterruptInArduino(const int gpio_pin) : gpio_pin_(gpio_pin) {
+  }
 
   void begin() const override;
 

andino_firmware/include/andino/bsp/pwm_out_arduino.h

@@ -39,7 +39,8 @@ class PwmOutArduino : public PwmOut {
   /// @brief Constructs a PwmOutArduino using the specified GPIO pin.
   ///
   /// @param gpio_pin GPIO pin.
-  explicit PwmOutArduino(const int gpio_pin) : gpio_pin_(gpio_pin) {}
+  explicit PwmOutArduino(const int gpio_pin) : gpio_pin_(gpio_pin) {
+  }
 
   void begin() const override;
 

andino_firmware/include/andino/bsp/serial_stream_arduino.h

@@ -39,7 +39,8 @@ namespace andino {
 class SerialStreamArduino : public SerialStream {
  public:
   /// @brief Constructs a SerialStreamArduino.
-  explicit SerialStreamArduino() : SerialStream() {}
+  explicit SerialStreamArduino() : SerialStream() {
+  }
 
   void begin(unsigned long baud) const override;
 

andino_firmware/include/andino/drivers/encoder.h

@@ -81,7 +81,8 @@ class Encoder {
   /// @param channel_b_interrupt_in Digital interrupt input connected to encoder channel B pin.
   Encoder(const InterruptIn* channel_a_interrupt_in, const InterruptIn* channel_b_interrupt_in)
       : channel_a_interrupt_in_(channel_a_interrupt_in),
-        channel_b_interrupt_in_(channel_b_interrupt_in) {}
+        channel_b_interrupt_in_(channel_b_interrupt_in) {
+  }
 
   /// @brief Initializes the encoder.
   void begin();

andino_firmware/include/andino/drivers/motor.h

@@ -83,7 +83,8 @@ class Motor {
         const PwmOut* backward_pwm_out)
       : enable_digital_out_(enable_digital_out),
         forward_pwm_out_(forward_pwm_out),
-        backward_pwm_out_(backward_pwm_out) {}
+        backward_pwm_out_(backward_pwm_out) {
+  }
 
   /// @brief Initializes the motor.
   void begin();